etr2460 commented on a change in pull request #17410:
URL: https://github.com/apache/superset/pull/17410#discussion_r755583651
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
##########
@@ -323,7 +323,9 @@ const FilterBar: React.FC<FiltersBarProps> = ({
activeKey={editFilterSetId ? TabIds.AllFilters : undefined}
>
<Tabs.TabPane
- tab={`${t('All filters')} (${numberOfFilters})`}
+ tab={t('All filters (%(filterCount)d)', {
Review comment:
i don't think you need the `d` here since you're not changing the
content based on the filterCount. did you verify that this renders properly on
the page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
