geido opened a new pull request #17570: URL: https://github.com/apache/superset/pull/17570
### SUMMARY This PR fixes a severe issue for which changes in the properties modal of a Dashboard won't be fully saved when the `onlyApply` prop was used. This PR https://github.com/apache/superset/pull/17392 enabled the `onlyApply` tag. Later, manual tests have shown that the tag wasn't ready to be used as both the frontend and the backend were not fully implemented for that to work properly. In addition to that, this PR does the following: - Refactors the `PropertiesModal` to use typescript - Fixes an issue in the Dashboard detail page for which when applying changes and re-opening the properties modal it would not show the latest changes - Fixes an issue for which changes in the json_metadata for namespace, expanded_slices, timed_refresh_immune_slices were not saved ### TESTING INSTRUCTIONS 1. Open a Dashboard 2. Edit the properties, including the json metadata 3. Apply the changes 4. Reopen the modal and make sure the latest changes are there 4. Finally, save the changes 5. Reload the Dashboard and make sure the properties were fully saved ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
