geido commented on a change in pull request #17570:
URL: https://github.com/apache/superset/pull/17570#discussion_r761315664



##########
File path: 
superset-frontend/spec/javascripts/dashboard/components/PropertiesModal_spec.jsx
##########
@@ -59,7 +59,8 @@ fetchMock.get('glob:*/api/v1/dashboard/*', {
   },
 });
 
-describe('PropertiesModal', () => {
+// all these tests need to be moved to 
dashboard/components/PropertiesModal/PropertiesModal.test.tsx
+describe.skip('PropertiesModal', () => {

Review comment:
       All these tests need to be refactored since this PR changes the 
component to be functional. I'll work on these in a separate PR to avoid 
holding this PR too long




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to