villebro commented on a change in pull request #17589:
URL: https://github.com/apache/superset/pull/17589#discussion_r759075187
##########
File path: superset/views/core.py
##########
@@ -1526,7 +1538,7 @@ def available_domains(self) -> FlaskResponse: # pylint:
disable=no-self-use
def fave_dashboards_by_username(self, username: str) -> FlaskResponse:
"""This lets us use a user's username to pull favourite dashboards"""
user = security_manager.find_user(username=username)
- return self.fave_dashboards(user.get_id())
+ return self.fave_dashboards(int(user.get_id()))
Review comment:
`user.get_id()` returns a string, so this should be cast to an int.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
