villebro commented on a change in pull request #17589:
URL: https://github.com/apache/superset/pull/17589#discussion_r759085095
##########
File path: superset/security/manager.py
##########
@@ -1160,6 +1160,18 @@ def get_rls_ids(self, table: "BaseDatasource") ->
List[int]:
ids.sort() # Combinations rather than permutations
return ids
+ @staticmethod
+ def raise_for_user_activity_access(user_id: int) -> None:
+ id_ = int(g.user.get_id())
Review comment:
Good point about `g.user`, will address. And good question about
`g.user.get_id()` - I just noticed `g.user.get_id()` is used fairly
prevalently, so I assumed it was the preferred way. `user.id` sounds better
here IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
