[GitHub] [superset] ofekisr commented on a change in pull request #16991: fix(QueryContext): validation does not validate query_context metrics

Tue, 30 Nov 2021 01:25:31 -0800 


ofekisr commented on a change in pull request #16991:
URL: https://github.com/apache/superset/pull/16991#discussion_r759080431



##########
File path: superset/charts/data/commands/get_data_command.py
##########
@@ -14,6 +14,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+from __future__ import annotations
+

Review comment:
       https://docs.python.org/3/library/__future__.html
   
   
![image](https://user-images.githubusercontent.com/35701650/144020171-d5ecaa5e-c8df-4aac-8499-8455b071f98f.png)
   
   you should add it until all supported versions are at least 3.11 
   
   I use that future for the type hints 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to