ofekisr commented on a change in pull request #16991:
URL: https://github.com/apache/superset/pull/16991#discussion_r759100390
##########
File path: superset/charts/data/commands/get_data_command.py
##########
@@ -14,6 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from __future__ import annotations
+
Review comment:
@villebro
regarding the FF, I don't agree with it since the change is fixing a bug a
not adding new functionality.
if someone will encounter a surprising issue with it, it means "hey it got
something, we have a security breach" so the app administrator should think
about how to solve it, giving extra permission or removing the metric.
this is my IMO, but for now I'll add that FF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
