villebro commented on a change in pull request #17622:
URL: https://github.com/apache/superset/pull/17622#discussion_r760800673
##########
File path: superset/utils/network.py
##########
@@ -38,8 +38,6 @@ def is_port_open(host: str, port: int) -> bool:
finally:
s.close()
- return False
Review comment:
bycatch: I notice that `port` is an `int ` in the argument list, but
we're recasting it to `int` on line 33, which is unnecessary. While we're at
it, I'd almost recommend removing that cast, and make sure code ever calls this
function with anything except an `int` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
