PApostol commented on a change in pull request #17622:
URL: https://github.com/apache/superset/pull/17622#discussion_r761452120
##########
File path: superset/utils/network.py
##########
@@ -38,8 +38,6 @@ def is_port_open(host: str, port: int) -> bool:
finally:
s.close()
- return False
Review comment:
Good spot; I have taken out the `int` cast - by the looks of it,
`is_port_open()` is only used
[here](https://github.com/apache/superset/blob/master/superset/db_engine_specs/base.py#L1544),
where `port` is indeed an integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
