craig-rueda commented on a change in pull request #17543:
URL: https://github.com/apache/superset/pull/17543#discussion_r765174201
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1790,23 +1806,448 @@ def before_update(
raise Exception(get_dataset_exist_error_msg(target.full_name))
@staticmethod
- def update_table(
- _mapper: Mapper, _connection: Connection, obj: Union[SqlMetric,
TableColumn]
+ def update_table( # pylint: disable=unused-argument
+ mapper: Mapper, connection: Connection, target: Union[SqlMetric,
TableColumn]
) -> None:
"""
Forces an update to the table's changed_on value when a metric or
column on the
table is updated. This busts the cache key for all charts that use the
table.
- :param _mapper: Unused.
- :param _connection: Unused.
- :param obj: The metric or column that was updated.
+ :param mapper: Unused.
Review comment:
Would it make sense to pull this hook logic out into each "New" model's
respective classes? This is a rather large block and could use a little breakup
:).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
