betodealmeida commented on a change in pull request #17543:
URL: https://github.com/apache/superset/pull/17543#discussion_r765312448
##########
File path: superset/connectors/sqla/models.py
##########
@@ -71,12 +72,14 @@
from sqlalchemy.sql.selectable import Alias, TableClause
from superset import app, db, is_feature_enabled, security_manager
+from superset.columns.models import Column as NewColumn
from superset.common.db_query_status import QueryStatus
from superset.connectors.base.models import BaseColumn, BaseDatasource,
BaseMetric
from superset.connectors.sqla.utils import (
get_physical_table_metadata,
get_virtual_table_metadata,
)
+from superset.datasets.models import Dataset as NewDataset
Review comment:
After this PR the plan is to get rid of the old models, so this will go
away before we have v3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]