villebro commented on a change in pull request #17702:
URL: https://github.com/apache/superset/pull/17702#discussion_r765795306
##########
File path: superset/viz.py
##########
@@ -373,6 +375,15 @@ def query_obj(self) -> QueryObjectDict: # pylint:
disable=too-many-locals
self.from_dttm = from_dttm
self.to_dttm = to_dttm
+ # validate sql filters
+ for param in ("where", "having"):
Review comment:
I know.. I considered splitting this out into a util, but then decided
not to as I'm still hopeful we can remove this file some day, in which case the
util would no longer be needed. But happy to follow up and DRY it up if people
feel strongly about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
