villebro commented on a change in pull request #17702:
URL: https://github.com/apache/superset/pull/17702#discussion_r765860104
##########
File path: superset/sql_parse.py
##########
@@ -378,3 +380,23 @@ def set_or_update_query_limit(self, new_limit: int, force:
bool = False) -> str:
for i in statement.tokens:
str_res += str(i.value)
return str_res
+
+
+def validate_filter_clause(clause: str) -> None:
Review comment:
I agree this module is slightly messy right now, but it's not totally
clear to me how this functionality will evolve. Since we already have some
util-type of functionality, I will add this here for now, but going forward
this should probably be refactored. But that refactoring should not be done as
part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
