eschutho commented on a change in pull request #17988:
URL: https://github.com/apache/superset/pull/17988#discussion_r781682820
##########
File path: superset-frontend/src/components/ReportModal/index.tsx
##########
@@ -338,16 +349,16 @@ const ReportModal: FunctionComponent<ReportProps> = ({
value={currentReport?.description || ''}
validationMethods={{
onChange: ({ target }: { target: HTMLInputElement }) =>
- onChange(ActionType.inputChange, {
+ onReducerChange(ActionType.inputChange, {
name: target.name,
value: target.value,
}),
}}
- errorMessage={
- currentReport?.description === 'error' ? t('DESCRIPTION ERROR') :
''
- }
- label="Description"
- placeholder="Include a description that will be sent with your
report"
+ errorMessage=""
Review comment:
where do you display the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
