eschutho commented on a change in pull request #17988:
URL: https://github.com/apache/superset/pull/17988#discussion_r782652464
##########
File path: superset-frontend/src/components/ReportModal/index.tsx
##########
@@ -316,18 +329,16 @@ const ReportModal: FunctionComponent<ReportProps> = ({
id="name"
name="name"
value={currentReport?.name || ''}
- placeholder="Weekly Report"
+ placeholder={t('Weekly Report')}
required
validationMethods={{
onChange: ({ target }: { target: HTMLInputElement }) =>
- onChange(ActionType.inputChange, {
+ onReducerChange(ActionType.inputChange, {
name: target.name,
value: target.value,
}),
}}
- errorMessage={
- currentReport?.name === 'error' ? t('REPORT NAME ERROR') : ''
- }
+ errorMessage={currentReport?.error || ''}
Review comment:
how/when does this error get cleared out? Does it stay visible until
they hit submit again? I'm not sure if we discussed how this should look
@yousoph?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
