AAfghahi commented on a change in pull request #18131:
URL: https://github.com/apache/superset/pull/18131#discussion_r790987670
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -550,28 +550,13 @@ class Header extends React.PureComponent {
{this.state.showingPropertiesModal && (
<PropertiesModal
dashboardId={dashboardInfo.id}
+ dashboardInfo={dashboardInfo}
Review comment:
this is from: https://github.com/apache/superset/pull/17570/files it
looks like it wasn't added correctly in a merge. I added it here to pass CI
though I think it will be eliminated when the feature branch gets rebased and
merged into master.
##########
File path: superset-frontend/src/views/CRUD/alert/types.ts
##########
@@ -81,14 +82,15 @@ export type AlertObject = {
sql?: string;
timezone?: string;
recipients?: Array<Recipient>;
- report_format?: 'PNG' | 'CSV' | 'TEXT';
+ report_format?: 'PNG' | 'CSV' | 'TEXT' | string;
Review comment:
ok done
##########
File path: superset-frontend/src/views/CRUD/alert/types.ts
##########
@@ -81,14 +82,15 @@ export type AlertObject = {
sql?: string;
timezone?: string;
recipients?: Array<Recipient>;
- report_format?: 'PNG' | 'CSV' | 'TEXT';
+ report_format?: 'PNG' | 'CSV' | 'TEXT' | string;
Review comment:
Ok done. Thank you for pointing this out, I put this in to fix a quick
TS bug then got bogged down with other things and forgot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
