AAfghahi commented on a change in pull request #18131:
URL: https://github.com/apache/superset/pull/18131#discussion_r796013282
##########
File path: superset-frontend/src/reports/actions/reports.js
##########
@@ -164,7 +164,7 @@ export function deleteActiveReport(report) {
dispatch(addDangerToast(t('Your report could not be deleted')));
})
.finally(() => {
- dispatch(deleteReport(report.id));
+ dispatch(deleteReport(report));
Review comment:
I played around with this, and it doesn't work very well with the new
way that we structured the fetch action to get rid of the racing condition for
hydrating a dashboard.
I was working through the logic for making the setReport action also
consider a deleteAction, and then realized that I was just writing a delete
action, so wrote it that way instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
