villebro opened a new pull request #18252: URL: https://github.com/apache/superset/pull/18252
### SUMMARY This fixes a bug in the ECharts timeseries chart, where using a metric with a verbose name caused the forecast and observations to be on separate series (one with the verbose name, and the other with the raw name). A test is also added that ensures verbose names are correctly handled going forward. In addition, all references to "prophet" are replaced with "forecast" in preparation for decoupling the forecasting functionality from Prophet. ### AFTER Now the metric with a verbose name displays correctly in both the chart and the tooltip:  The forecast section is also split up into one control per line:  ### BEFORE Previously, the predictions would show up as different series with their non-verbose name, both on the chart and the tooltip  Before, the forecast section headers wrapping caused the controls to be misaligned:  ### TESTING INSTRUCTIONS 1. Create a v2 Line chart 2. Add the built-in `COUNT(*)` metric as your primary metric 3. Enable the forecast ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
