villebro commented on pull request #18252:
URL: https://github.com/apache/superset/pull/18252#issuecomment-1027827385


   > The fix doesn't seem to be working well with `GENERIC_CHART_AXES` ff 
disabled - Y axis is scaled to timestamp epoch values
   > 
   > 
![image](https://user-images.githubusercontent.com/15073128/152141623-55edfb43-645d-4f32-ac8e-0e967038fa9e.png)
   
   Great catch! It turns out `datasource.verboseMap` always includes an entry 
`{ __timestamp: 'Time' }` which threw the util function off when it was made 
more generic. I added added a check for it + added a test for making sure the 
alias stays unchanged (this logic will be removed once we remove the legacy 
non-generic timeseries functionality).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to