hughhhh commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r803191820
##########
File path: superset-frontend/src/views/components/Menu.tsx
##########
@@ -185,6 +185,24 @@ export function Menu({
const screens = useBreakpoint();
const uiConig = useUiConfig();
+ const nonItemsToRender = {
+ 'Upload a CSV': 'Upload a CSV',
Review comment:
instead of doing this just comment out the childs that we don't want to
render, and remove the if condition in `createPlusMenuItems`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]