hughhhh commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r803193504
##########
File path: superset-frontend/src/views/components/Menu.test.tsx
##########
@@ -89,6 +89,44 @@ const mockedProps = {
url: '/dashboard/list/',
index: 4,
},
+ {
+ name: 'Data',
+ icon: 'fa-database',
+ label: 'Data',
+ childs: [
+ {
+ name: 'Databases',
+ icon: 'fa-database',
+ label: 'Databases',
+ url: '/databaseview/list/',
+ },
+ {
+ name: 'Datasets',
+ icon: 'fa-table',
+ label: 'Datasets',
+ url: '/tablemodelview/list/',
+ },
+ '-',
Review comment:
> can we just remove the items we childs units we don't want to add
instead of adding additional logic?
Remove these items
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
