ad-m commented on a change in pull request #18652:
URL: https://github.com/apache/superset/pull/18652#discussion_r803269470
##########
File path: superset-embedded-sdk/package.json
##########
@@ -22,7 +22,7 @@
"module": "lib/index.js",
"types": "dist/index.d.ts",
"scripts": {
- "build": "tsc & babel src --out-dir lib --extensions '.ts,.tsx' & webpack
--mode production",
+ "build": "tsc ; babel src --out-dir lib --extensions '.ts,.tsx' ; webpack
--mode production",
Review comment:
```suggestion
"build": "tsc && babel src --out-dir lib --extensions '.ts,.tsx' &&
webpack --mode production",
```
I suggest use ``&&`` to execute that in series only if the predecessor was
successful. In other words, stop as soon as an error occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
