suddjian commented on a change in pull request #18652:
URL: https://github.com/apache/superset/pull/18652#discussion_r804997790
##########
File path: superset-embedded-sdk/package.json
##########
@@ -22,7 +22,7 @@
"module": "lib/index.js",
"types": "dist/index.d.ts",
"scripts": {
- "build": "tsc & babel src --out-dir lib --extensions '.ts,.tsx' & webpack
--mode production",
+ "build": "tsc ; babel src --out-dir lib --extensions '.ts,.tsx' ; webpack
--mode production",
Review comment:
These aren't really dependent on each other's result. Running each of
them regardless of the others' status can output more useful information in the
case of an error. Ideally I'd like to run them in parallel and wait for all to
complete before the command exits, but I am not familiar with a convenient way
to do that without writing a script, and that seems like overkill since these
all run in about a second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
