villebro commented on pull request #18181: URL: https://github.com/apache/superset/pull/18181#issuecomment-1041503788
I agree with @michael-s-molina - we really should have surfaced this as a SIP, and this was clearly a fault in the process, and I assume full responsibility for my part in this oversight. My sincerest apologies for this. I will do my best to make sure similar lapses in process don't happen in the future. I think the points brought up above were a good summary of why we felt this change was needed and why this approach was taken, but obviously this discussion should have taken place prior to PRs in the open. Like @nytai mentioned, the fallout caused by this will be difficult to undo at this point, but any potential improvements that come to mind are warmly welcomed and would be good to address before the 1.5 and 2.0 cuts. One safeguard that comes to mind is adding an optional allowlist to `config.py` for acceptable cache backends. By setting `ALLOWED_CACHE_BACKENDS = ["RedisCache"]`, it would be possible to ensure that cache misconfigurations like these would be caught during testing. On a related note, it appears the long URL problem has gotten worse when moving from 1.3 to 1.4: #18198 (I have been unable to identify what is causing this). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
