ktmud opened a new pull request #18799: URL: https://github.com/apache/superset/pull/18799
### SUMMARY Remove the loading indicator in select option menus when the user is typing. The loading indicator showing up as users type is added in #16712 but the original feature that PR implemented seems to be working fine even without this behavior. Remove this unnecessary loading indicator makes the control feels faster. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before The "Loading..." option shows up as soon as users type, even when all options are loaded:  #### After No "Loading..." option when users start to type, but there is a loading indicator in the input and all filtered options will show up after actual loading is finished:  When all options are loaded for a specific search string, there is no loading indicator at all and no excessive requests will be fired. ### TESTING INSTRUCTIONS 1. Run `npm run storybook` in `superset-frontend` 2. Test it in the storybook: http://localhost:6006/?path=/story/select--async-select ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #16712 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
