michael-s-molina commented on a change in pull request #18799:
URL: https://github.com/apache/superset/pull/18799#discussion_r813090622
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -63,12 +62,7 @@ type PickedSelectProps = Pick<
| 'value'
>;
-type OptionsProps = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export interface OptionsType extends Omit<OptionsProps, 'label'> {
- label?: string;
- customLabel?: ReactNode;
-}
Review comment:
@ktmud The objective of the extension is to change the type of `label`
from `React.Node` to `string` and to introduce another property called
`customLabel` that accepts a `React.Node`. You can search from `customLabel` to
see where it's being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
