kasiazjc commented on pull request #18784: URL: https://github.com/apache/superset/pull/18784#issuecomment-1046816416
> I have 2 questions for the new look: 1, the clear all button is always grey out and make me feel like it is disable, also i feel like the buttons are not consistent, for example the clear button did not have a background but apply all have a grey back ground, and it makes me feel like apply is more standout > > <img alt="Screen Shot 2022-02-18 at 12 38 20 PM" width="1792" src="https://user-images.githubusercontent.com/81597121/154758060-2cf8eb2a-3abc-4846-ac9d-f56e7f232abc.png";> > > 2, if i have multiple filters, the scroll bar is hidden, and user need to move the mouse into the filters area to be able to scroll, and there in no clear window to guide the user to move the mouse, which could be a little confusing? > > filter.bar.in.visible.mov Thank you for feedback @jinghua-qa! 1. We want to make the apply all more visible than the clear all, so that's why we have this hierarchy + difference. Plus, it's a standard pattern for this kind of components - usually in filter components "Clear all" action is less visible and shown as a link, so I wouldn't say it's inconsistent when it comes to types of the buttons, it's just a different pattern. I agree though, that clear all seemed like it's disabled at all times, so @kgabryje added different states for disabled, active and hover, but the idea is to still keep this hierarchy we have and not overuse the colours. 2. I think the hidden scroll bar shouldn't be a problem as it's a natural behaviour/flow. Design wise, scroll bars are usually hidden also in the components that have an internal scroll, not only websites or apps. The gradient that we added should be able to help with it a little bit. It works the same in different parts of app though and in the filter boxes, tables etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/81597121/154758060-2cf8eb2a-3abc-4846-ac9d-f56e7f232abc.png"](https://user-images.githubusercontent.com/81597121/154758060-2cf8eb2a-3abc-4846-ac9d-f56e7f232abc.png"){kind=link}