[GitHub] [superset] kgabryje commented on pull request #18784: feat(native-filters): Re-arrange controls in FilterBar

[GitBox]

kgabryje commented on pull request #18784:
URL: https://github.com/apache/superset/pull/18784#issuecomment-1046807989


   Thanks for the comments @jinghua-qa! After consulting with @kasiazjc I 
changed the default color of "Clear all" to a darker one (first screenshot) and 
changed the color on hover (second screenshot). The light grey color is now 
only used when button is disabled. As for the apply button standing out - it 
does stand out by design as it calls a more important action than clear all.
   <img width="211" alt="image" 
src="https://user-images.githubusercontent.com/15073128/154951951-8aa59d5d-eb90-407a-a624-b6a442a0d0ae.png";>
   <img width="176" alt="image" 
src="https://user-images.githubusercontent.com/15073128/154951991-083ddd5c-8240-4bdd-922f-144612e180ce.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org