geido commented on a change in pull request #18835:
URL: https://github.com/apache/superset/pull/18835#discussion_r811238436
##########
File path:
superset-frontend/packages/superset-ui-core/src/query/buildQueryObject.ts
##########
@@ -89,6 +92,14 @@ export default function buildQueryObject<T extends
QueryFormData>(
...extras,
...filterFormData,
});
+ const isAdhocColumn = (v?: AdhocColumn | PhysicalColumn) =>
Review comment:
This would require adding the chart controls as a dependency. We have
`isPhysicalColumn` in packages/superset-ui-core/src/query/types/Column.ts. I am
adding `isAdhocColumn` there too for convenience. We should probably better
separate these type guards in the future and make them available everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
