geido commented on a change in pull request #18835:
URL: https://github.com/apache/superset/pull/18835#discussion_r811238864
##########
File path:
superset-frontend/packages/superset-ui-core/src/query/buildQueryObject.ts
##########
@@ -89,6 +92,14 @@ export default function buildQueryObject<T extends
QueryFormData>(
...extras,
...filterFormData,
});
+ const isAdhocColumn = (v?: AdhocColumn | PhysicalColumn) =>
+ (v as AdhocColumn)?.sqlExpression !== undefined;
+ const normalizeSeriesLimitMetric = (v: QueryFormColumn | undefined) => {
+ if (isAdhocColumn(v) || (v as PhysicalColumn)?.length) {
Review comment:
Yup! I edited the `isPhysicalColumn` to accept an undefined value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
