eschutho commented on a change in pull request #18722:
URL: https://github.com/apache/superset/pull/18722#discussion_r813222694
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -144,9 +158,30 @@ const RightMenu = ({
{menu.label}
</>
);
+
+ const handleMenuSelection = (itemChose: React.Key) => {
+ if (itemChose === GlobalMenuDataOptions.DB_CONNECTION) {
+ setShowModal(true);
+ setEngine('');
Review comment:
I think it's ok to leave the logic here for which engine was chosen, but
maybe instead of clearing it out on menu selection, we can clear out the engine
value on the dbmodal onHide event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
