hughhhh commented on a change in pull request #18722:
URL: https://github.com/apache/superset/pull/18722#discussion_r813433502
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -163,13 +186,17 @@ const RightMenu = ({
className="data-menu"
title={menuIconAndLabel(menu)}
>
- {menu.childs.map(item =>
+ {menu.childs.map((item, idx) =>
typeof item !== 'string' &&
item.name &&
configMap[item.name] === true ? (
- <Menu.Item key={item.name}>
- <a href={item.url}> {item.label} </a>
- </Menu.Item>
+ <>
+ {idx === 2 && <Menu.Divider />}
Review comment:
if we go above idx > 1, this would render after every menu item after
the first 2 items. We just want it to render it once right after the db
connection buttons. Thats the one of the main reason i split out the db
connection buttons from the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
