michael-s-molina commented on a change in pull request #18799:
URL: https://github.com/apache/superset/pull/18799#discussion_r813758394
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -63,12 +62,7 @@ type PickedSelectProps = Pick<
| 'value'
>;
-type OptionsProps = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export interface OptionsType extends Omit<OptionsProps, 'label'> {
- label?: string;
- customLabel?: ReactNode;
-}
Review comment:
I can't remember any particular reason. I guess it was just a style
choice when we were designing the API. I don't see any problem in changing that
to Select property called `optionRenderer` if you want. It's being used only by
10 files so it would be really easy to migrate.
@geido Please correct me if I'm forgetting anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
