ktmud commented on a change in pull request #18799:
URL: https://github.com/apache/superset/pull/18799#discussion_r813457584
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -63,12 +62,7 @@ type PickedSelectProps = Pick<
| 'value'
>;
-type OptionsProps = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export interface OptionsType extends Omit<OptionsProps, 'label'> {
- label?: string;
- customLabel?: ReactNode;
-}
Review comment:
I'm also curious why did we decide to introduce a `customLabel` prop
instead of using
[optionRenderer](https://github.com/apache/superset/blob/46715b295c3026c3eb1ee439f1d16fc776e61372/superset-frontend/src/components/Select/DeprecatedSelect.tsx#L87)
like in the old Select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
