villebro commented on a change in pull request #18794: URL: https://github.com/apache/superset/pull/18794#discussion_r814660501
########## File path: tests/unit_tests/business_type/types_tests.py ########## @@ -0,0 +1,523 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# isort:skip_file +"""Unit tests for Superset""" + +from ipaddress import ip_address +import sqlalchemy +from sqlalchemy import Column, Integer +from tests.integration_tests.base_tests import SupersetTestCase +from superset.business_type.business_type_request import BusinessTypeRequest +from superset.business_type.business_type_response import BusinessTypeResponse +from superset.utils.core import FilterOperator, FilterStringOperators + +from superset.business_type.internet_address import internet_address +from superset.business_type.port import port + + +class TestBusinessType(SupersetTestCase): Review comment: These tests would be nice to convert to functional tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
