villebro commented on a change in pull request #18794:
URL: https://github.com/apache/superset/pull/18794#discussion_r814662127



##########
File path: superset/business_type/internet_address.py
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       This file (and `port.py`) should preferably be placed in a sub-package 
like `plugins` or similar to distinguish them from the other more generic code 
here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to