[GitHub] [superset] ktmud opened a new pull request #18952: fix(select): fix typing for customLabel

[GitBox]

ktmud opened a new pull request #18952:
URL: https://github.com/apache/superset/pull/18952


   ### SUMMARY
   
   Typing for `option.customLabel` in the Select component is not correctly 
applied because it extended the wrong source type. This should fix it. No 
changes to code functionalities whatsoever.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   `.customLabel` is `any` where it was referenced:
   
   <img width="663" alt="Xnip2022-02-25_11-28-36" 
src="https://user-images.githubusercontent.com/335541/155780133-0b3ebec6-d8c3-4ac2-98bb-6f3d624dea5a.png";>
   
   #### After
   
   `.customLabel` is ReactNode
   
   <img width="746" alt="Xnip2022-02-25_11-06-30" 
src="https://user-images.githubusercontent.com/335541/155780483-149a59a4-b11e-4dde-8121-10b97d5515ca.png";>
   
   
   ### TESTING INSTRUCTIONS
   
   CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: this issue was caught while I was working on 
#18799 
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org