ktmud commented on a change in pull request #18952:
URL: https://github.com/apache/superset/pull/18952#discussion_r816162581
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -44,7 +43,21 @@ import { hasOption } from './utils';
const { Option } = AntdSelect;
-type AntdSelectAllProps = AntdSelectProps<AntdSelectValue>;
+export type RawValue = string | number;
+
+export interface LabeledValue {
+ key?: string;
+ value: RawValue;
+ label: ReactNode;
Review comment:
I understand the intention but changing it to `ReactNode` will cause too
many incompatibility in other references of the `Select` component. Ideally we
should probably refactor `customLabel` to something akin to `optionalRenderer`.
It also doesn't feel right for a data fetching API (the `options` promise) to
return `ReactNode`. Data fetching and rendering should be two separate things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
