graceguo-supercat commented on a change in pull request #18793:
URL: https://github.com/apache/superset/pull/18793#discussion_r819366422
##########
File path:
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -91,9 +91,9 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
topLevelTabs }) => {
const { scope } = filterScope;
const chartsInScope: number[] = getChartIdsInFilterScope({
filterScope: {
- scope: scope.rootPath,
+ scope: scope?.rootPath,
Review comment:
In what cases `scope` field could be optional? I thought all filter has
default "all" scope and [] for immune.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
