geido commented on a change in pull request #19049:
URL: https://github.com/apache/superset/pull/19049#discussion_r823607854
##########
File path: superset-frontend/src/views/components/Menu.tsx
##########
@@ -97,6 +96,17 @@ const StyledHeader = styled.header`
display: flex;
flex-direction: column;
justify-content: center;
+ min-height: ${({ theme }) => `${theme.gridUnit * 12.5}px`};
+ padding: ${({ theme }) =>
+ `${theme.gridUnit}px ${theme.gridUnit * 2}px ${theme.gridUnit}px ${
+ theme.gridUnit * 4
+ }px`};
+ max-width: ${({ theme }) => `${theme.gridUnit * 37}px`};
Review comment:
The problem with using the `APP_ICON_WIDTH` here is that it would not
behave the same as it used to. I think best is not to use it or change it with
`APP_ICON_MAX_WIDTH` for clarity, if that can be of any benefit to the users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
