geido commented on a change in pull request #19049:
URL: https://github.com/apache/superset/pull/19049#discussion_r823609795
##########
File path: superset/config.py
##########
@@ -236,7 +236,6 @@ def _try_json_readsha(filepath: str, length: int) ->
Optional[str]:
# Specify the App icon
APP_ICON = "/static/assets/images/superset-logo-horiz.png"
-APP_ICON_WIDTH = 126
Review comment:
@rusackas I think the configurability brings a bit of complexity to it.
If there is a strong signal from the community that they need the
`APP_ICON_WIDTH`, we should probably add another config flag, such as
`USE_APP_ICON_FORCED_WIDTH = Boolean`, and then behave consistently with that
when True. When False just fallback to the implementation of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
