kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837397650
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -97,26 +101,55 @@ const DatasourceContainer = styled.div`
`;
const LabelWrapper = styled.div`
- overflow: hidden;
- text-overflow: ellipsis;
+ ${({ theme }) => css`
+ overflow: hidden;
+ text-overflow: ellipsis;
+ font-size: ${theme.typography.sizes.s}px;
+ background-color: ${theme.colors.grayscale.light4};
+ margin: ${theme.gridUnit * 2}px 0;
+ border-radius: 4px;
Review comment:
I don't think that is related to gridUnit. Supposedly, if we created a
theme where distances between components are bigger, that doesn't mean we want
the corners to be more rounded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
