[GitHub] [superset] kgabryje commented on a change in pull request #19394: feat(explore): UI changes in dataset panel on Explore page

[GitBox]

kgabryje commented on a change in pull request #19394:
URL: https://github.com/apache/superset/pull/19394#discussion_r837480017



##########
File path: superset-frontend/src/dashboard/components/dnd/DragHandle.tsx
##########
@@ -17,33 +17,35 @@
  * under the License.
  */
 import React, { LegacyRef } from 'react';
-import cx from 'classnames';
+import { css, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
 
 interface DragHandleProps {
   position: 'left' | 'top';
-  innerRef: LegacyRef<HTMLDivElement> | undefined;
-  dotCount: number;
+  innerRef?: LegacyRef<HTMLDivElement> | undefined;
 }
 
+const DragHandleContainer = styled.div<{ position: 'left' | 'top' }>`
+  ${({ theme, position }) => css`
+    margin-bottom: ${theme.gridUnit}px !important;

Review comment:
       👍 
   Looks good after changing to height: 20, thanks for the tip
   <img width="613" alt="image" 
src="https://user-images.githubusercontent.com/15073128/160622851-00e092c7-d313-49f3-93aa-dbf1387a4483.png";>
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org