ktmud commented on a change in pull request #19383:
URL: https://github.com/apache/superset/pull/19383#discussion_r838887651
##########
File path:
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/ColumnConfigControl/constants.tsx
##########
@@ -191,12 +204,14 @@ export const DEFAULT_CONFIG_FORM_LAYOUT:
ColumnConfigFormLayout = {
'columnWidth',
{ name: 'horizontalAlign', override: { defaultValue: 'left' } },
],
+ ['truncateLongCells'],
['d3TimeFormat'],
],
[GenericDataType.BOOLEAN]: [
[
'columnWidth',
{ name: 'horizontalAlign', override: { defaultValue: 'left' } },
],
+ ['truncateLongCells'],
Review comment:
I don't think we need this configuration for boolean, temporal and
numeric columns:
1. They are usually short enough
2. They should display full values under any conditions anyway for data
accuracy.
##########
File path:
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/ColumnConfigControl/constants.tsx
##########
@@ -142,6 +143,15 @@ const colorPositiveNegative:
ControlFormItemSpec<'Checkbox'> = {
debounceDelay: 200,
};
+const truncateLongCells: ControlFormItemSpec<'Checkbox'> = {
+ controlType: 'Checkbox',
+ label: t('Truncate Cells'),
+ description: t('Truncate long cells to the "min width" set above'),
+ width: 150,
Review comment:
Does change the width here fix the jumpy info tooltip icon? (It should
be on the same line as the checkbox label)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
