stevetracvc commented on a change in pull request #19383:
URL: https://github.com/apache/superset/pull/19383#discussion_r838924053
##########
File path:
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/ColumnConfigControl/constants.tsx
##########
@@ -191,12 +204,14 @@ export const DEFAULT_CONFIG_FORM_LAYOUT:
ColumnConfigFormLayout = {
'columnWidth',
{ name: 'horizontalAlign', override: { defaultValue: 'left' } },
],
+ ['truncateLongCells'],
['d3TimeFormat'],
],
[GenericDataType.BOOLEAN]: [
[
'columnWidth',
{ name: 'horizontalAlign', override: { defaultValue: 'left' } },
],
+ ['truncateLongCells'],
Review comment:
So I originally was thinking that too and left it out for everything
except string, but then I thought that it might be better to allow the option
(since it is off by default anyway). Dates could be formatted in a way that's
wider than what you want, maybe. And possibly some numbers. There's also the
formatting styles you can choose for numbers, which might make this feature
unnecessary for numbers. I dunno, I'll leave it up to you. I haven't used it
for anything other than string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
