eschutho commented on code in PR #19569:
URL: https://github.com/apache/superset/pull/19569#discussion_r844339479
##########
superset/databases/utils.py:
##########
@@ -112,7 +112,9 @@ def make_url_safe(raw_url: str) -> URL:
:param raw_url:
:return:
"""
+
+ url = str(raw_url).strip()
Review Comment:
Actually now that I look at the function parameter types for the original
make_url, it can take a URL and then just returns the same URL. Good catch. I
think I'll do the same here.
##########
superset/databases/utils.py:
##########
@@ -112,7 +112,9 @@ def make_url_safe(raw_url: str) -> URL:
:param raw_url:
:return:
"""
+
+ url = str(raw_url).strip()
Review Comment:
Actually now that I look at the function parameter types for the original
make_url, it can take a URL and then just returns the same URL. Good call. I
think I'll do the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
