etr2460 commented on code in PR #19569:
URL: https://github.com/apache/superset/pull/19569#discussion_r844347290
##########
superset/databases/utils.py:
##########
@@ -112,7 +112,9 @@ def make_url_safe(raw_url: str) -> URL:
:param raw_url:
:return:
"""
+
+ url = str(raw_url).strip()
Review Comment:
Thanks for making the change. We definitely want the type hints to match the
actual types passed in. mypy should ideally catch this when type checking too,
i'm wondering why that wasn't the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
