villebro opened a new pull request, #19772:
URL: https://github.com/apache/superset/pull/19772

   ### SUMMARY
   The PR #18181 changed dashboard chart permalinks to link to explore view, 
while previously they would create a permalink to the dashboard with an anchor 
pointing to the chart. This changes this behavior back to how it was originally 
implemented.
   
   ### AFTER
   Now the permalink will link to the dashboard with the chart anchor:
   
   
https://user-images.githubusercontent.com/33317356/163965896-dfa1f844-901b-4927-bebf-41120c78c076.mp4
   
   ### BEFORE
   Before the permalink sent the user to explore:
   
   
https://user-images.githubusercontent.com/33317356/163966169-6f89f746-8af0-4370-848e-82121b259e4b.mp4
   
   ### TESTING INSTRUCTIONS
   1. go to the Video Games Dashboard
   2. Go to the "Explore Trends" tab
   3. Copy a permalink from one of the charts
   4. follow the permalink and see where you end up
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to