villebro commented on code in PR #19772:
URL: https://github.com/apache/superset/pull/19772#discussion_r853345097
##########
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx:
##########
@@ -49,23 +45,17 @@ const ShareMenuItems = (props: ShareMenuItemProps) => {
addDangerToast,
addSuccessToast,
dashboardId,
- formData,
+ hash,
Review Comment:
I would have personally gone with `anchor`, but
1. the previous implementation used the term `hash`
2. I found references to `hash` elsewhere, too:
https://www.w3schools.com/jsref/prop_anchor_hash.asp
So I went with `hash`. Since it's already in the schema, I think it might be
a good idea to leave it like that, but I'm happy to change it if you feel even
remotely strongly about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
