ktmud opened a new pull request, #19942: URL: https://github.com/apache/superset/pull/19942
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Simplify the state reducer for `ReportModal` and improve error handling: 1. Reduce indirectness in the state reducer 2. Refactor `getClientError` to more consistently handle validation `message` from Marshmallow (set the default `"error"` message to be the first error of the first validated field). 3. Update the error message for name uniqueness to include the referred duplicate name, to make it sound more friendly 4. Editing a report will also display errors in an inline Alert instead of in a toast ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before https://user-images.githubusercontent.com/335541/166630300-41eb948b-3b72-4d79-a238-22da7908731a.mp4 #### After https://user-images.githubusercontent.com/335541/166630843-305bd2fa-4f5f-4c93-886e-db57387cb098.mp4 ### TESTING INSTRUCTIONS Go to dashboard or chart page to create or edit a report ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
